Should IDisposable.Dispose() implementations be idempotent?
.net, c#, idempotent, memory-management
Solution
should the implementation of the `Dispose()` method be idempotent
Yes, it should. There is no telling how many times it will be called.
From Implementing a Dispose Method on MSDN:
a Dispose method should be callable multiple times without throwing an exception.
An object with a good implementation of `IDispose` will have a boolean field flag indicating if it has been disposed of already and on subsequent calls do nothing (as it was already disposed).
Problem
The Microsoft.NET framework provides the `IDisposable` interface which requires an implementation of `void Dispose()` method. Its purpose is to enable manual, or scope-based releasing of expensive resources an `IDisposable` implementation may have allocated. Examples include database collections, streams and handles. My question is, should the implementation of the `Dispose()` method be idempotent - when called more than once on the same instance, the instance to be 'disposed of' only once, and subsequent calls not to throw exceptions. In Java, most of the objects that have similar behavior (again streams and database connections come to my mind as examples) are idempotent for their `close()` operation, which happens to be the analogue for the `Dispose()` method. However, my personal experience with .NET (and Windows Forms in particular), shows that not all implementations (that are part of the .NET framework itself) are idempotent, so that subsequent calls to these throw an `ObjectDisposedException`. This really confuses me on how a disposable object's implementation should be approached. Is there a common answer for the scenario, or is it dependent on the concrete context of the object and its usage?