RecyclerView and java.lang.IndexOutOfBoundsException Invalid view holder adapter positionViewHolder

Question

I have a `RecyclerView` that binds a grocery item. Adding the item works perfectly. However, when I try to delete the item the app crashes and I get the `IndexOutOfBoundsException` error. The problem I am facing is in my `onBindViewHolder()`. I tried to get the adapter position and that did not solve the problem. I also just tried using `notifyDataSetChanged()` and that just deleted my entire list. My question is what am I doing wrong and how do I fix this problem? Here is the Adapter class: ``` private class GroceryAdapter extends RecyclerView.Adapter{ private List groceries; private GroceryHolder holder; public GroceryAdapter(){ setGroceries(GroceryList.get(GroceryActivity.this).getGroceries()); } public void setGroceries(List groceries){ this.groceries = groceries; } @Override public GroceryHolder onCreateViewHolder(ViewGroup parent, int viewType){ LayoutInflater layoutInflater= LayoutInflater.from(GroceryActivity.this); View view=layoutInflater.inf…

Accepted Answer

You should not pass `final int position` to your anonymous `new View.OnClickListener()` Instead, use `holder.getAdapterPosition()`: ``` private class GroceryAdapter extends RecyclerView.Adapter { private List groceries; public GroceryAdapter(List groceries) { this.groceries = groceries; } @Override public GroceryHolder onCreateViewHolder(ViewGroup parent, int viewType){ LayoutInflater layoutInflater= LayoutInflater.from(GroceryActivity.this); View view=layoutInflater.inflate(R.layout.grocery_list_row, parent, false); holder = new GroceryHolder(view); return holder; } @Override public void onBindViewHolder(final GroceryHolder holder, int position){ int safePosition = holder.getAdapterPosition(); final Grocery grocery = groceries.get(safePosition); holder.bindGrocery(grocery); holder.deleteImageButton.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { // delete item from the list groceries.remove(safePosition); groceryAdapter.notifyItemRemoved(safePosition); Toast.makeText(getApplicationContext(),"Item deleted", Toast.LENGTH_SHORT).show(); } }); } @Override public int getItemCount(){ return groceries.size(); } } ``` In addition, there are few more unrelated issues: it would be better to set `setOnClickListener` not in `onBindViewHolder`, but in `onCreateViewHolder` Code around setting the list of groceries in constructor looks too complex. Could be much simpler to pass this list as an argument from your Activity/Fragment. `private GroceryHolder holder` as instance variable is unnecessary Here is more context on `holder.getAdapterPosition()` https://youtu.be/imsr8NrIAMs?t=2092

RecyclerView and java.lang.IndexOutOfBoundsException Invalid view holder adapter positionViewHolder

Solution

Problem