Switch statement with returns -- code correctness

c, correctness, switch-statement

Solution

Remove the `break` statements. They aren't needed and perhaps some compilers will issue "Unreachable code" warnings.

Problem

Let's say I have code in C with approximately this structure: ``` switch (something) { case 0: return "blah"; break; case 1: case 4: return "foo"; break; case 2: case 3: return "bar"; break; default: return "foobar"; break; } ``` Now obviously, the `break`s are not necessary for the code to run correctly, but it sort of looks like bad practice if I don't put them there to me. What do you think? Is it fine to remove them? Or would you keep them for increased "correctness"?

Original source