Override http status code from validator

c#, fluentvalidation, http-status-codes, servicestack

Solution

Am I misusing validation feature? (i.e. autowired validators were not designed to be used for application logic checks)

I would say this is best done in the business logic away from the validation, because checking for a uniqueness is actually a verification check rather than validation, because it requires checking against a data source. My answer on this question addresses a similar concern.

While you can override the response status code of the validation error using the `ErrorResponseFilter`, I would recommend creating your own request filter for this business logic, as overriding the response there will be messy as your application grows, and again, it's not really validation.

Using a filter attribute is straightforward in ServiceStack:

public class VerifySomethingCodeAttribute : Attribute, IHasRequestFilter
{
    IHasRequestFilter IHasRequestFilter.Copy()
    {
        return this;
    }

    public int Priority { get { return int.MinValue; } }

    public void RequestFilter(IRequest req, IResponse res, object requestDto)
    {
        SomethingRequest somethingRequestDto = requestDto as SomethingRequest;
        if(somethingRequestDto == null)
            return;

        // Verify the code
        // Replace with suitable logic
        // If you need the database your wire it up from the IoC
        // i.e. HostContext.TryResolve<IDbConnectionFactory>();
        bool isUnique = ...

        if(!isUnique)
            throw HttpError.Conflict("This record already exists");
    }
}

Then simply annotate the DTO:

[VerifySomethingCode]
public class SomethingRequest {
    public string Code { get; set; }
}

Then you can be sure that the Code in the DTO will have been verified as unique and you can return any status and response you want. The filter gives you total control.

Hope this helps.

Problem

I've got the following DTO: ``` public class SomethingRequest { public string Code { get; set; } } ``` `Code` must be unique, so I've created a validator that checks if there is already a record with provided code, like the following ``` public class SomethingValidator: AbstractValidator<SomethingRequest> { public SomethingValidator(ISomethingRepository repo) { RuleFor(something => something.Code).Must(BeUnique); } private bool BeUnique(string code) { ... uniqueness check... } } ``` As I'm using validation feature, the validator is automatically wired for all methods with `SomethingRequest`, which is really great. When condition fails I would like to return `409 Conflict` HTTP status code, but `400 Bad Request` is always returned. So, the questions are: - Am I misusing vaidation feature? (i.e. autowired validators were not designed to be used for application logic checks) - If I'm not, are there any ways to override `400 BadRequest` status code from validator?

Original source

Related problems