JToolBar IllegalArgumentException when dropped back into GridBagLayout

Question

Why does this code throw an `IllegalArgumentException` when the tool bar is dragged off the GUI, then closed (to return it to the GUI)? I could understand why it might be improper to add a component with no constraint, but in this case, the initial addition of the toolbar to the panel (which uses `GridBagLayout`) without a constraint causes no such problem. Why should it occur the 2nd and subsequent times it is added? The code is adapted from this answer, but both codes show the same problem. Code ``` import java.awt.*; import javax.swing.*; public class GridBagToolBarOddity { public static void main(String[] args) { Runnable r = new Runnable() { @Override public void run() { JPanel gui = new JPanel(new GridBagLayout()); JToolBar tb = new JToolBar(); tb.add(new JLabel("Drag me off, then drop me back!")); gui.add(tb); gui.setPreferredSize(new Dimension(300, 100)); gui.setBackground(Color.RED); JFrame f = new JFrame("Demo"); f.add(gui); f.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE…

Accepted Answer

That's snippet from BasicToolBarUI source

```
    public void windowClosing(WindowEvent w) {
        if (toolBar.isFloatable()) {
            if (dragWindow != null)
                dragWindow.setVisible(false);
            floating = false;
            if (floatingToolBar == null)
                floatingToolBar = createFloatingWindow(toolBar);
            if (floatingToolBar instanceof Window) ((Window)floatingToolBar).setVisible(false);
            floatingToolBar.getContentPane().remove(toolBar);
            String constraint = constraintBeforeFloating;
            if (toolBar.getOrientation() == JToolBar.HORIZONTAL) {
                if (constraint == "West" || constraint == "East") {
                    constraint = "North";
                }
            } else {
                if (constraint == "North" || constraint == "South") {
                    constraint = "West";
                }
            }
            if (dockingSource == null)
                dockingSource = toolBar.getParent();
            if (propertyListener != null)
                UIManager.removePropertyChangeListener(propertyListener);
            dockingSource.add(toolBar, constraint);
```

As you can see it tries to pass constraintBeforeFloating String as constraint but GridBagLayout expects GridBagConstraints.

```
constraintBeforeFloating = calculateConstraint();
```

and

```
private String calculateConstraint() {
    String constraint = null;
    LayoutManager lm = dockingSource.getLayout();
    if (lm instanceof BorderLayout) {
        constraint = (String)((BorderLayout)lm).getConstraints(toolBar);
    }
    return (constraint != null) ? constraint : constraintBeforeFloating;
}
```

So when floating is closed UI tries to pass curretn constraint (String) to GridBagLayout and fails.

JToolBar IllegalArgumentException when dropped back into GridBagLayout

Solution

Problem