Why is cyclomatic complexity of those methods so high?
c#, code-metrics, visual-studio-2012
Solution
It is an imperfect tool. It sees IL, the code that's generated by the C# compiler. It does not see your code. And there is plenty of syntax sugar in C# that was designed to make your code simple to understand but has an iceberg of code-gen below the water-line. Query comprehensions certainly fit that pattern.
Use CC only as a guide, never let it set the rules and never let it cramp your style. Your brain outsmarts any tool.
Problem
Metrics are calcucated using Visual Studio. First method has CC = 4 ``` private IEnumerable<string> GetRows(DataTable dt, string columnDelimiter) { return from DataRow row in dt.Rows select string.Join(columnDelimiter, row.ItemArray.Select(k => k.ToString())); } ``` Second method has CC = 5. ``` private IEnumerable<string> GetRowsForeach(DataTable dt, string columnDelimiter) { var rows = new List<string>(); foreach (DataRow row in dt.Rows) { var rowString = string.Join(columnDelimiter, row.ItemArray.Select(k => k.ToString())); rows.Add(rowString); } return rows; } ``` I'd say that first method should have CC = 1 and second maybe CC = 1 or maybe 2 (understanding foreach as for with end condition. But I would never say their CC is so high. What am I misunderstanding?