AngularJS : Why is my factory always undefined in my controller?

Question

My factory is undefined in my controller and I cannot figure out why. I have created a simple example to illustrate. Here I create the app: ``` var ruleApp = angular .module( "ruleApp", [ "ngRoute", "ruleApp.NewFactory1", "ruleApp.NewFactory2", ] ); ``` In this dummy example I'd like to build a factory that does something simple, show an alert box. I'll show two methods of doing this (one works, one does not). Factory 1: ``` angular .module('ruleApp.NewFactory1', []) .factory('NewFactory1', function() { return function(msg) { alert(msg); }; }); ``` Factory 2: ``` angular .module('ruleApp.NewFactory2', []) .factory('NewFactory2', function() { var showMessageFunction = function(msg) { alert(msg); }; return { showMessage: showMessageFunction }; }); ``` Notice the return type of factory 1 is a function and the return type of factory 2 is an object with a property (which is of type function). Now look at how I'd like to use both of these factories in my controller: ``` ruleApp.controller(…

Accepted Answer

factory 2 should be (demo)

```
angular
.module('ruleApp.NewFactory2', [])
.factory('NewFactory2', function() {
    var showMessageFunction = function(msg) {
        alert(msg);
    };
    return {    // <--------- do not go on a new line after return
        showMessage: showMessageFunction
    };
});
```

AngularJS : Why is my factory always undefined in my controller?

Solution

Problem

Related problems