Multiple Insert statements in one connection

Question

I need some tips on how to do this better, I am inserting multiple queries with using one connection. I understand this is not good programming, especially with it being very prone to sql injection, I also wanted to mention it's not going to be out on the internet just run locally. This is what I have so far.. ``` public partial class Modify : System.Web.UI.Page { OleDbConnection connection; OleDbCommand command; public void OpenConnection2() { connection = new OleDbConnection(""); command = new OleDbCommand(); connection.Open(); } protected void btnSave_Click1(object sender, EventArgs e) { if (AcctNumList.SelectedValue == "3") { string query2 = String.Format(@"INSERT INTO ACH (rptid, tableid, name, amount, stat, create_date) values ('{0}','{1}','{2}','{3}','{4}','{5}')", id, newguid, Name1TxtBox.Text.Replace("'", "''"), Amt1TxtBox.Text.Replace("'", "''"), 3, DateTime.Now.ToString()); string query3 = String.Format(@"INSERT INTO ACH (rptid, tableid, name, amount, stat, create_date) val…

Accepted Answer

You should parameterized your query - ALWAYS, but for now you can concatenate those queries with `;` and then execute them once like:

```
string allQueries = string.join(';', query2, query3, query4, query5);
command.CommandText = allQueries; 
int c = command.ExecuteNonQuery();
```

Currently you are just executing one query. Semicolon `;` marks end of statement in SQL, so combining these statements with `;` will make them separate statements but they will be executed under one execution.

kcray - This is what worked for me.

```
 string[] arr = { query2, query3 };
 string allQueries = string.Join(";", arr);
 command.CommandText = allQueries;
 int c = command.ExecuteNonQuery();
```

Multiple Insert statements in one connection

Solution

Problem