flash message not displaying after redirect or render

Question

Using rails 4 and ruby 2 Having trouble displaying the flash messages from my controllers. My method looks like this: ``` def create @salary_report = SalaryReport.create(salary_report_params) if @salary_report.save redirect_to @salary_report flash[:notice] = "Lönerapporten sparades korrekt!" puts "salary report saved #{flash[:notice]}" else render :new, notice: "Något gick fel när lönerapporten skulle sparas!" end end ``` As you can see, I have added a puts statement printing out the flash notice just to prove that the flash notice is getting generated after the redirect. The logs look like this after creating a salary report: ``` Redirected to http://localhost:3000/salary_reports/20 salary report saved Lönerapporten sparades korrekt! Completed 302 Found in 25ms (ActiveRecord: 9.7ms) ``` After getting to show view logs: ``` Started GET "/salary_reports/22" for 127.0.0.1 at 2013-07-24 16:08:42 +0200 Processing by SalaryReportController#show as HTML Parameters: {"id"=>"22"} SalaryReport…

Accepted Answer

You are setting your `flash[:notice]` after redirect. Try switching the order of those calls i.e. set the flash message first then redirect second:

```
def create
    @salary_report = SalaryReport.create(salary_report_params)
    if @salary_report.save  
      flash[:notice] = "Lönerapporten sparades korrekt!"
      puts "salary report saved #{flash[:notice]}"
      redirect_to @salary_report
    else
      render :new, notice: "Något gick fel när lönerapporten skulle sparas!"      
    end
  end
```

flash message not displaying after redirect or render

Solution

Problem