Django Class Based Views, get_absolute_url not working

Question

I bought and am Reading the Book Two Scoops of Django:Best Practices for Django 1.5 and in it has a example of Class based views. After this implementation I get the error after submitting the form. ``` ImproperlyConfigured at /NonProfitCreate/ No URL to redirect to. Either provide a url or define a get_absolute_url method on the Model ``` Doing research I came along this problem Django - Class Based Generic View - "No URL to redirect to" I want the get_absolute_url to work in my program this is my forms.py ``` #!/usr/bin/env python # -*- coding: utf-8 -*- # # npp/forms.py from django import forms from .models import NonProfit class NonProfitCreateForm(forms.ModelForm): class Meta: model = NonProfit fields = ("name","contact_name","email","phone","address","image","tags",) def __init__(self, *args, **kwargs): self.request = kwargs.pop('request', None) return super(NonProfitCreateForm, self).__init__(*args, **kwargs) def save(self, *args, **kwargs): kwargs['commit']=False obj = super(N…

Accepted Answer

This exception is produced because `self.object = None` when attempting to redirect after a valid edit. Since the value of `self.object` is the result of a `form.save()` call, the most likely reason for this error is that you have overridden the `save()` method in `NonProfitCreateForm`, but forgotten to return the saved object.

The `Form.save()` method is expected to return the object that was saved and should not be `None`.

Your `NonProfitCreateForm` could be modified as shown below:

```
class NonProfitCreateForm(forms.ModelForm):
    ...
    def save(self, *args, **kwargs):
        kwargs['commit']=False
        obj = super(NonProfitCreateForm, self).save(*args, **kwargs)
        if self.request:
            obj.user = self.request.user
            obj.save()
        return obj #<--- Return saved object to caller.
```

The first two lines of your `save()` method will create a model instance from the entered form data. But because `commit=False`, the object will not be saved to the database. If `self.request` is not present on your form instance, a the returned object will not have a database primary key, and `get_absolute_url` will still fail.

So, you want to ensure that a `request` parameter is always passed to your form when instantiated. This doesn't happen by default, so you need to arrange your view code to instantiate your form with a `request` parameter.

Looking through the code for `FormMixin` you can see that there is a `get_form_kwargs` function which determines the arguments to pass to any instantiated form. You need to pass `request=self.request`, so in your view override `get_form_kwargs` to add the required parameter, something like this:

```
class NonProfitCreateView(LoginRequiredMixin,ActionMixin,CreateView):
    model = NonProfit
    action = "created"
    form_class = NonProfitCreateForm

def get_form_kwargs(self):
        # Ensure the current `request` is provided to NonProfitCreateForm.
        kwargs = super(NonProfitCreateView, self).get_form_kwargs()
        kwargs.update({ 'request': self.request })
        return kwargs
```

It would probably be a better idea to create a subclass of `CreateView` with the modified `get_form_kwargs` function, and have your `NonProfitCreateView` derive from the subclass.

Django Class Based Views, get_absolute_url not working

Solution

Problem

Related problems