Is using return at the start of method bad coding practice?
java
Solution
It is good practice to return at the earliest opportunity. That way the least amount of code gets executed and evaluated.
Code that does not run cannot be in error.
Furthermore it makes the function easier to read, because you do not have to deal with all the cases that do not apply anymore.
Compare the following code
private Date someMethod(Boolean test) {
Date result;
if (null == test) {
result = null
} else {
result = test ? something : other;
}
return result;
}
vs
private Date someMethod(Boolean test) {
if (null == test) {
return null
}
return test ? something : other;
}
The second one is shorter, does not need an else and does not need the temp variable.
Note that in Java the `return` statement exits the function right away; in other languages (e.g. Pascal) the almost equivalent code `result:= something;` does not return. Because of this fact it is customary to return at many points in Java methods. Calling this `bad practice` is ignoring the fact that that particular train has long since left the station in Java.
If you are going to exit a function at many points in a function anyway, it's best to exit at the earliest opportunity
Problem
I have found myself using the following practice, but something inside me kind of cringes every time i use it. Basically, it's a precondition test on the parameters to determine if the actual work should be done. ``` public static void doSomething(List<String> things) { if(things == null || things.size() <= 0) return; //...snip... do actual work } ```