Redirect loop with node express.js

Question

I have simple webpage with `/about`, `/contact`, `/home` and `/lessons` routes defined. All routes work okay except for `/lessons`. I instantly get a redirect loop (`Error 310 (net::ERR_TOO_MANY_REDIRECTS): There were too many redirects`). Here's my main `server.js` code : ``` var port = process.env.PORT || 8888; var app = require('./app').init(port); var markdown = require('./markdown'); var lessons = require('./lessons.json').lessons; // app.use(function(req,res,next) { // console.log('adding lessons to locals'); // res.locals.date = new Date().toLocaleDateString(); // res.locals.lessons = lessons; // next(); // }); // app.use(app.router); app.get('/', function (req, res) { console.log('controller is : home'); res.locals.controller = 'home'; res.render('home'); }); app.get('/:controller', function (req, res, next) { var controller = req.params.controller; console.log('controller is : '+ controller); if (controller == 'about' || controller == 'contact') { res.locals.controller = cont…

Accepted Answer

This happens:

- a request for `/lessons` comes in;

- the static middleware sees the `public/lessons` folder and assumes that's what the intended target is; because it's a folder, it will generate a redirect to `/lessons/` (see below);

- static middleware picks that request up again, but notices there's no `index.html` in that folder, and hands it off to the next middleware (`connect-slashes`);

- the `connect-slashes` middleware removes the trailing slash and issues a redirect to `/lessons`;

- the whole loop starts again;

You can prevent the static middleware from adding a trailing slash, which will fix your redirect loop I think:

```
app.use(express.static(__dirname + '/public', { redirect : false }));
```

Redirect loop with node express.js

Solution

Problem