java.lang.IllegalStateException: attempt to re-open an already-closed object(Tried closing )

Question

``` public int getRecordsCount() { String countQuery = "SELECT * FROM " + TABLE_LOGIN; SQLiteDatabase db = this.getReadableDatabase(); Cursor cursor = db.rawQuery(countQuery, null); if(cursor != null && !cursor.isClosed()){ cursor.close(); } // return count return cursor.getCount(); } ``` I am trying to get the totalnumber of records in the database, but the database is getting crashed everytime with `java.lang.IllegalStateException: attempt to re-open an already-closed object: android.database.sqlite.SQLiteQuery (mSql = SELECT * FROM login)` . Please help me with the error ``` 03-05 22:23:14.208: E/AndroidRuntime(4988): FATAL EXCEPTION: main 03-05 22:23:14.208: E/AndroidRuntime(4988): java.lang.IllegalStateException: attempt to re-open an already-closed object: android.database.sqlite.SQLiteQuery (mSql = SELECT * FROM login) 03-05 22:23:14.208: E/AndroidRuntime(4988): at android.database.sqlite.SQLiteClosable.acquireReference(SQLiteClosable.java:34) 03-05 22:23:14.208: E/AndroidRunti…

Accepted Answer

You should call `getCount()` before you close your cursor.

Move:

```
if(cursor != null && !cursor.isClosed()){
    cursor.close();
} 
```

below:

```
 cursor.getCount();
```

like this:

```
public int getRecordsCount() {
    int count = 0;
    String countQuery = "SELECT  * FROM " + TABLE_LOGIN;

SQLiteDatabase db = this.getReadableDatabase();
    Cursor cursor = db.rawQuery(countQuery, null);

if(cursor != null && !cursor.isClosed()){
        count = cursor.getCount();
        cursor.close();
    }   
    return count;
}
```

java.lang.IllegalStateException: attempt to re-open an already-closed object(Tried closing )

Solution

Problem