Long if statements and PSR-2

coding-style, php

Solution

How about making it a one-liner to avoid that problem and make the statement more readable:

$blockModeIsHidevar = $field->getBlockMode() == FieldInterface::BLOCK_MODE_HIDEVAR;
$blockNotEnabled = !isset($this->enabledBlocks[$field->getBlock()]);

if ($blockModeIsHidevar && $blockNotEnabled) {

}

Alternative:

I usually do it with methods, this could looke like that:

if ($this->blockModeIsHidevar($field) && $this->blockNotEnabled($field)) {

}
// ...
private function blockModeIsHidevar($field)
{
    return $field->getBlockMode() == FieldInterface::BLOCK_MODE_HIDEVAR
}
private function blockNotEnabled($field)
{
    return !isset($this->enabledBlocks[$field->getBlock()])
}

This way, the optimization of `&&` still takes place.

Problem

I'm about to migrate some code to the PSR-2 standard. In my code i have if statements with multiple lines as expression: ``` if ( $field->getBlockMode() == FieldInterface::BLOCK_MODE_HIDEVAR && !isset($this->enabledBlocks[$field->getBlock()]) ) { } ``` What's the best practice to write such expressions?

Original source