Codeigniter - Session expiration and "remember me" feature

codeigniter, php

Solution

The simpliest solution that I have found for this problem is to just modify the cookie created by Codeigniter by this way:

        $this->session->set_userdata('user', $user); // a cookie has been created
        if($this->input->post('remember_me'))
        {
            $this->load->helper('cookie');
            $cookie = $this->input->cookie('ci_session'); // we get the cookie
            $this->input->set_cookie('ci_session', $cookie, '35580000'); // and add one year to it's expiration
        }

Problem

I'm building a "Remember Me" feature in Codeigniter, normally I see libraries/projects setting a cookie on the user with a token, this token gets saved in the database and is compared each time the user accesses the website. In Codeigniter we can set the session expiration time though, this lead me to try a different approach, this is what I did: - I set the session_expiration in config to 0 (infinite session) - If the user leaves "Remember me" unchecked, I set a 2 hour time in the session and session destroy on window close. So my login code looks like this: ``` if (!$this->input->post('remember_me')) { $this->session->sess_expiration = 7200; $this->session->sess_expire_on_close = TRUE; } $this->session->set_userdata($session_data); ``` And my config file: ``` $config['sess_expiration'] = 0; $config['sess_expire_on_close'] = FALSE; ``` I don't see people using this solution on projects, I have tested this out and it seems to work fine though. SO, for my question, would you say this a safe practice to do? Any security dangers I should know about? Any input on this solution vs cookie+database token would be great.

Original source