C++ Assignment of boolean condition values within if statement not working?

Question

I've been coding a game in C++ using the SDL library. Today while changing the way my player character class works, I've come up against a very puzzling problem. The following code forms part of my logic allowing the player to fire bullets. The control variables, b_canFire and b_shouldFire (I plan to rename these to make more sense), are set elsewhere in the class to allow this function to execute when the user presses a key. ``` bool PlayerChar::DoFiring() { if(b_canFire && b_shouldFire) { Fire(box.x + 22, box.y); // This fires a bullet b_canFire = false; // Does not work b_shouldFire = false; // Does not work return true; } } ``` When I step through this code using my debugger, it becomes aparrent that the values of b_canFire and b_shouldFire are not being changed to false by the assignments inside the if statement. However, if I change the code to the following: ``` bool PlayerChar::DoFiring() { if((b_canFire) && (b_shouldFire)) { Fire(box.x + 22, box.y); // This fires a bullet b_c…

Accepted Answer

It is missing last return instruction in your function:

```
bool PlayerChar::DoFiring()
{
    if(b_canFire && b_shouldFire)
    {
        Fire(box.x + 22, box.y); // This fires a bullet
        b_canFire = false; // Does not work
        b_shouldFire = false; // Does not work

return true;
    }
    return false; // WAS MISSING HERE
}
```

Then your function returns whatever (UB) if any of your b_canFire, b_shouldFire are false.

C++ Assignment of boolean condition values within if statement not working?

Solution

Problem