Model best practices in ASP.NET MVC

Question

I've got two questions related to the best way to manage a model in an mvc project. - Can i use a constructor for initialize my model (obviously with its related logic)? - For this purpose, is better to use "the constructor way", or I should use extension method called by controller after the creation of the new model instance? For example I've a model for a contact form. User can be in three roles: anonymous, client or supplier and he can submit the form in each state. The only thing that I want is that if the user is logged in (like client's role or supplier's role) I want to preload in textboxes his datas. For do this I've wrote this code: ``` using System; using System.Web; using System.Web.Security; using DrOkR2.Bll.Managers; namespace DrOkR2.WebFront.Models { public class RequestModel { public string FirstName { get; set; } public string LastName { get; set; } public string Phone { get; set; } public string Email { get; set; } public string Prov { get; set; } public string Reque…

Accepted Answer

No, you should not have a dependency on `HttpContext` or any data access in your models. You're opening yourself up to all kinds of problems with model binding (not to mention tightly coupled).

Set your model properties in your Controller, or a repository that is used by your Controller.

```
public ActionResult Contact(string id)
{
   var client = _repository.GetClient(id);
   var model = new RequestModel(){ /* set your properties from client */ };

return View(model);
}
```

Model best practices in ASP.NET MVC

Solution

Problem