PDO UPDATE creates a new record instead of updating one

Question

I'm using the following code to update a record. Bad thing is that it's not updating a record but it's adding a new record. What am I doing wrong? I want it to update the record and not create a now one. My modify url looks like this: http://randomsite.com/modify.php?id=1 Modify.php code: ``` prepare($query); $result->execute(array(':id' => $_REQUEST['id']) ); while ($row = $result->fetch(PDO::FETCH_ASSOC)) { ?>

Modify a car

Accepted Answer

Your SQL should look something more like this:

```
   $q = "UPDATE cars SET 
          id = :id, 
          brand = :brand, 
          model = :model, 
          year = :year 
          WHERE id = :oldid";

$query = $odb->prepare($q);
    $results = $query->execute(array(
            ":id"    => $id,
            ":brand" => $brand,
            ":model" => $model,
            ":year"  => $year,
            ":oldid" => $_GET['id'],
    ));
```

As a side note, try not to put variables in your SQL (like your $_GET['id']), part of the idea of using PDO is to avoid doing that.

PDO UPDATE creates a new record instead of updating one

Solution

Problem