Improve on a 13-parameter constructor

Question

Thank Microsoft for Intellisense and Atomineer for Atomineer Utils...All of these parameters are required and immutable. Is there a better way to do this? ``` /************************************************************************************************** *

Initializes a new instance of the ADTBattleCharacter class.

* The name of the character. * The maximum hit points. * The maximum magic power. * The strength. * The agility. * The attack power. * The defense power. * The gold carried by the character. * The experience the character is worth. * The character's resistance to stopspell. * The character's resistance to slee…

Accepted Answer

Looking at your specific case, it seems to me that you haven't broken things out very well.

Conceptually, a character in your system has:

- A name.

- A stat block, containing their basic stats (HP, defense, etc).

- The character's secondary attributes (experience).

- An inventory, which would include their current list of spells and their gold, among potentially other things.

That's 4 parameters, not 13. When you're writing a function, and you see that it's taking a large number of parameters, odds are good that some of those parameters are conceptually linked to each other. And odds are also good that other functions will want to use those linked parameters.

For example, you may want to display a character's stat block. Does the function that does this really need the character? No; it just needs the stat block. So it should take a stat block object.

Just like the character's constructor does.

Improve on a 13-parameter constructor

Solution

Problem