Android: SqLite database illegal state exception (database already closed)

Question

I have a database helper object. It is important I close it when leaving the activity, so I do. However, on returning to the activity I get a warning about querying a database that has already been closed. The query actually works, but there's still something obviously wrong. My understanding of the Android activity life cycle is not strong, but I would assume I need to reopen the database in onResume(). Is this not correct? Here is onResume(): ``` @Override protected void onResume() { super.onResume(); dbHelper.setInteger(playerID); dbHelper.openDataBase(); ourCursor = dbHelper.getPlayerSavedQuestions(); startManagingCursor(ourCursor); adapter = new MyCustomAdapter(ourCursor); myListView.setAdapter(adapter); } ``` Here is dbHelper.openDataBase(); ``` public void openDataBase() throws SQLException { String myPath = DATABASE_PATH + DATABASE_NAME; dbSqlite = SQLiteDatabase.openDatabase(myPath, null, SQLiteDatabase.OPEN_READWRITE); } ``` Here is my logcat: ``` 06-15 13:51:32.388: W/SQLit…

Accepted Answer

You need to instantiate your dbhelper class in `onResume`... that too (could possibly) get destroyed when you go away from the activity.

```
dbHelper = new YourDatabaseHelper();
```

Actually, since `onResume` is called even on a new start, you could move all your code there (and thus avoid instantiating you helper (and doing other things) twice.

Android: SqLite database illegal state exception (database already closed)

Solution

Problem