is call_user_func_array too slow?

mysql, php

Solution

You have a lot of things to address in your question - and `call_user_func_array` isn't one of them.

Look at your query

This is the sort of query you are building:

SELECT
    * 
FROM 
    trabajosEnSubasta 
WHERE 
    MATCH(titulo, descripcion, habilidades) AGAINST (?)
UNION 
    SELECT
        * 
    FROM 
        trabajosEnSubasta 
    WHERE 
        MATCH(titulo, descripcion, habilidades) AGAINST (?)
UNION 
    SELECT
        ...

And.. it begs the question why you'd do that. This is functionally identical, and likely much faster to execute:

SELECT
    * 
FROM 
    trabajosEnSubasta 
WHERE 
    MATCH(titulo, descripcion, habilidades) AGAINST (?)
    OR
    MATCH(titulo, descripcion, habilidades) AGAINST (?)
    OR
    ...

Look at your logic

$paramsArr = explode(",", $_GET['paramsQuery']);

Therefore requesting a url like `/foo?paramsQuery=a,b,c,d,e,f,g,h,i,j` will currently trigger a 10 table union query, if you update your query syntax, that'll be a 10 full-text-index query. Is that really what you want? It might be - but for example if someone searches for a known habilidad it'd be a lot more efficient to do:

SELECT
    trabajosEnSubasta.*
FROM
    trabajosEnSubasta
LEFT JOIN
    habilidades_map ON habilidades_map.trabajo_id = trabajosEnSubasta.id
WHERE
    habilidades_map.habilidad = "known habilidad"

A full-text index is relatively expensive to query, and shouldn't really be your only means of searching your data.

Profile your code

I have to assume you're asking about `call_user_func_array` because your code is slow to execute. Don't guess where problems are in code look and find out.

- Use explain to see what your queries are doing

- Use xdebug profiling to see where your code is spending it's time

- Webgrind is an easy to install means of seeing xdebug profile output.

Dont waste your time optimizing 0.01%

`call_user_func_array` does have a cost to use, and that's why code like this exists. BUT the difference is really, really insignificant (especially in light of the super-heavy UNION queries in the question) unless you're calling it hundreds+ times. Focus on the things that have the biggest performance impact on your application, not the things that make absolutely no measurable difference one way or the other.

Problem

Original source