Service has leaked IntentReceiver in android

Question

I am making an android app. I am making a service that runs in the background all the time when user checks a `checkbox` and it should stop when user `unckeck` it. So it does work when I check the box and it also shows "Service start" Toast but when I `uncheck` the `checkbox` then it shows the Toast that says "Service stopped" but it does not stop playing the sound which started when the service was started. The only way to stop that sound is to turn off my mobile and then turn it on. Here is my java code for starting and stopping service ``` public int onStartCommand(Intent intent, int flags, int startId) { Toast.makeText(this, "Service Started", Toast.LENGTH_LONG).show(); this.registerReceiver(this.batteryInfoReceiver, new IntentFilter(Intent.ACTION_BATTERY_CHANGED)); return START_STICKY; } public void onDestroy() { super.onDestroy(); Toast.makeText(this, "Service Stopped", Toast.LENGTH_LONG).show(); } ``` Here is my xml file ``` <CheckBoxPreference android:title="Enable/Disable Ala…

Accepted Answer

Make sure you call `unregisterReceiver`before the `onDestroy` finishes. After `onDestroy` the Service's context is invalid, so all registered intent receivers will stop operating. Android warns you with the "Leaked intent receiver" exception that your app is misbehaving.

The music does not stop because the receiver is not called any more. You should ensure that mMediaPlayer.stop is called before the return from onDestroy. I suggest you extracting all this functionality into separate methods, thus it will be much easier to compose your application.

```
private void startMusic(int level);
private void stopMusic();
```

Also, be careful not to leak the mMusicPlayer if due to error you receive two plugged == 2 intents in a row. It is always better to write your code in a defensive way, rather than relying on the invoker's additional knowledge.

The exception handling is also quite dangerous in your code. If the music starting failed, it may happen that you get a null pointer exception when you want to stop the music.

Hope this helps.

Service has leaked IntentReceiver in android

Solution

Problem